[SPARK-32080][SPARK-31998][SQL] Simplify ArrowColumnVector ListArray accessor #28915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This also avoid having to deal with an API change in the ArrowBuf class for Arrow 1.0.0 and will allow Arrow-Spark integration tests to run again in preparation for the 1.0.0 release, see apache/arrow#6316. |
viirya
approved these changes
Jun 24, 2020
Member
viirya
left a comment
viirya
left a comment
There was a problem hiding this comment.
I think this also covers SPARK-31998?
| int index = rowId * ListVector.OFFSET_WIDTH; | ||
| int start = offsets.getInt(index); | ||
| int end = offsets.getInt(index + ListVector.OFFSET_WIDTH); | ||
| int start = accessor.getElementStartIndex(rowId); |
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Thanks @viirya , I wasn't aware SPARK-31998 was made, but yes that was the motivation for this fix.
HyukjinKwon
changed the title
|
Test build #124451 has finished for PR 28915 at commit
|
Member
|
retest this please |
|
Test build #124470 has finished for PR 28915 at commit
|
Member
|
Merged to master and branch-3.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jun 24, 2020
…accessor ### What changes were proposed in this pull request? This change simplifies the ArrowColumnVector ListArray accessor to use provided Arrow APIs available in v0.15.0 to calculate element indices. ### Why are the changes needed? This simplifies the code by avoiding manual calculations on the Arrow offset buffer and makes use of more stable APIs. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests Closes #28915 from BryanCutler/arrow-simplify-ArrowColumnVector-ListArray-SPARK-32080. Authored-by: Bryan Cutler <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit df04107) Signed-off-by: HyukjinKwon <[email protected]>
Member
Author
|
Thanks @HyukjinKwon and @viirya ! |
BryanCutler
deleted the
arrow-simplify-ArrowColumnVector-ListArray-SPARK-32080
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change simplifies the ArrowColumnVector ListArray accessor to use provided Arrow APIs available in v0.15.0 to calculate element indices.
Why are the changes needed?
This simplifies the code by avoiding manual calculations on the Arrow offset buffer and makes use of more stable APIs.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests